fix: Prevent demo data from being created on edited tables #1005
Conversation
vsgoulart
force-pushed
the
997-demo-data
branch
from
d92aaac
to
8e2c9ca
Compare
| * | ||
| * @param {Field} field | ||
| */ | ||
| generateInitialDemoData: (field) => { |
There was a problem hiding this comment.
Generally, let's be careful with these kinds of changes. Our config object is tied in with the custom component framework and should be treated more or less as public API. Of course we're never obligated but changing how it's structured is something we should not do often.
I highly doubt anyone was using this already, considering how unique this stuff is, but this a breaking change if we were very strict about it.
Maybe it's worth annotating this as experimental, so that we can be safe in the future if we do decide to remove it entirely (which I believe will happen when we have more robust ways of doing demo data).
There was a problem hiding this comment.
Or moving it to an experimental sub-object, which should get the point across 🤔
There was a problem hiding this comment.
@Skaiir I added the @experimental tag
With the table component we added the concept of adding demo data to the new component, this data was being added when importing forms into the modeler.
This PR prevents this from happening and only adds the demo data when the schema matches with the demo data
Closes #997
form-jselement or visually changes an existing component.